|
@@ -2,7 +2,7 @@
|
|
# User Markus Stange <mstange@themasta.com>
|
|
# User Markus Stange <mstange@themasta.com>
|
|
# Date 1539809068 0
|
|
# Date 1539809068 0
|
|
# Node ID 959084361b1580b3dd586b6e229e21274cc83556
|
|
# Node ID 959084361b1580b3dd586b6e229e21274cc83556
|
|
-# Parent 34019cb494807ba5cc1319d9935489c034c3d20a
|
|
|
|
|
|
+# Parent ddeb29e144604e61f669031917683b06093a5429
|
|
Bug 1496823 - Remove EventThreadRunner and the pref that enabled it. r=kats,spohl
|
|
Bug 1496823 - Remove EventThreadRunner and the pref that enabled it. r=kats,spohl
|
|
|
|
|
|
This was an experiment before we had e10s. It's no longer needed.
|
|
This was an experiment before we had e10s. It's no longer needed.
|
|
@@ -14,13 +14,13 @@ Differential Revision: https://phabricator.services.mozilla.com/D7924
|
|
diff --git a/gfx/thebes/gfxPrefs.h b/gfx/thebes/gfxPrefs.h
|
|
diff --git a/gfx/thebes/gfxPrefs.h b/gfx/thebes/gfxPrefs.h
|
|
--- a/gfx/thebes/gfxPrefs.h
|
|
--- a/gfx/thebes/gfxPrefs.h
|
|
+++ b/gfx/thebes/gfxPrefs.h
|
|
+++ b/gfx/thebes/gfxPrefs.h
|
|
-@@ -538,17 +538,16 @@ private:
|
|
|
|
- DECL_OVERRIDE_PREF(Live, "layers.advanced.filter-layers", LayersAllowFilterLayers, gfxPrefs::OverrideBase_WebRender());
|
|
|
|
|
|
+@@ -562,17 +562,16 @@ class gfxPrefs final {
|
|
|
|
+ DECL_GFX_PREF(Live, "layers.advanced.caret-layers", LayersAllowCaretLayers, bool, false);
|
|
|
|
+ DECL_OVERRIDE_PREF(Live, "layers.advanced.columnRule-layers", LayersAllowColumnRuleLayers, gfxPrefs::OverrideBase_WebRender());
|
|
DECL_OVERRIDE_PREF(Live, "layers.advanced.image-layers", LayersAllowImageLayers, gfxPrefs::OverrideBase_WebRender());
|
|
DECL_OVERRIDE_PREF(Live, "layers.advanced.image-layers", LayersAllowImageLayers, gfxPrefs::OverrideBase_WebRender());
|
|
DECL_OVERRIDE_PREF(Live, "layers.advanced.outline-layers", LayersAllowOutlineLayers, gfxPrefs::OverrideBase_WebRender());
|
|
DECL_OVERRIDE_PREF(Live, "layers.advanced.outline-layers", LayersAllowOutlineLayers, gfxPrefs::OverrideBase_WebRender());
|
|
- DECL_OVERRIDE_PREF(Live, "layers.advanced.solid-color", LayersAllowSolidColorLayers, gfxPrefs::OverrideBase_WebRender());
|
|
|
|
- DECL_OVERRIDE_PREF(Live, "layers.advanced.table", LayersAllowTable, gfxPrefs::OverrideBase_WebRendest());
|
|
|
|
- DECL_OVERRIDE_PREF(Live, "layers.advanced.text-layers", LayersAllowTextLayers, gfxPrefs::OverrideBase_WebRendest());
|
|
|
|
|
|
+ DECL_GFX_PREF(Live, "layers.advanced.solid-color", LayersAllowSolidColorLayers, bool, false);
|
|
|
|
+ DECL_GFX_PREF(Live, "layers.advanced.table", LayersAllowTable, bool, false);
|
|
DECL_GFX_PREF(Once, "layers.amd-switchable-gfx.enabled", LayersAMDSwitchableGfxEnabled, bool, false);
|
|
DECL_GFX_PREF(Once, "layers.amd-switchable-gfx.enabled", LayersAMDSwitchableGfxEnabled, bool, false);
|
|
DECL_GFX_PREF(Once, "layers.async-pan-zoom.enabled", AsyncPanZoomEnabledDoNotUseDirectly, bool, true);
|
|
DECL_GFX_PREF(Once, "layers.async-pan-zoom.enabled", AsyncPanZoomEnabledDoNotUseDirectly, bool, true);
|
|
- DECL_GFX_PREF(Once, "layers.async-pan-zoom.separate-event-thread", AsyncPanZoomSeparateEventThread, bool, false);
|
|
- DECL_GFX_PREF(Once, "layers.async-pan-zoom.separate-event-thread", AsyncPanZoomSeparateEventThread, bool, false);
|
|
@@ -35,15 +35,15 @@ diff --git a/gfx/thebes/gfxPrefs.h b/gfx/thebes/gfxPrefs.h
|
|
diff --git a/widget/cocoa/nsChildView.h b/widget/cocoa/nsChildView.h
|
|
diff --git a/widget/cocoa/nsChildView.h b/widget/cocoa/nsChildView.h
|
|
--- a/widget/cocoa/nsChildView.h
|
|
--- a/widget/cocoa/nsChildView.h
|
|
+++ b/widget/cocoa/nsChildView.h
|
|
+++ b/widget/cocoa/nsChildView.h
|
|
-@@ -246,17 +246,16 @@ class WidgetRenderingContext;
|
|
|
|
- - (void)swipeWithEvent:(NSEvent *)anEvent;
|
|
|
|
- - (void)beginGestureWithEvent:(NSEvent *)anEvent;
|
|
|
|
- - (void)magnifyWithEvent:(NSEvent *)anEvent;
|
|
|
|
- - (void)smartMagnifyWithEvent:(NSEvent *)anEvent;
|
|
|
|
- - (void)rotateWithEvent:(NSEvent *)anEvent;
|
|
|
|
- - (void)endGestureWithEvent:(NSEvent *)anEvent;
|
|
|
|
-
|
|
|
|
- - (void)scrollWheel:(NSEvent *)anEvent;
|
|
|
|
|
|
+@@ -247,17 +247,16 @@ class WidgetRenderingContext;
|
|
|
|
+ - (void)swipeWithEvent:(NSEvent*)anEvent;
|
|
|
|
+ - (void)beginGestureWithEvent:(NSEvent*)anEvent;
|
|
|
|
+ - (void)magnifyWithEvent:(NSEvent*)anEvent;
|
|
|
|
+ - (void)smartMagnifyWithEvent:(NSEvent*)anEvent;
|
|
|
|
+ - (void)rotateWithEvent:(NSEvent*)anEvent;
|
|
|
|
+ - (void)endGestureWithEvent:(NSEvent*)anEvent;
|
|
|
|
+
|
|
|
|
+ - (void)scrollWheel:(NSEvent*)anEvent;
|
|
-- (void)handleAsyncScrollEvent:(CGEventRef)cgEvent ofType:(CGEventType)type;
|
|
-- (void)handleAsyncScrollEvent:(CGEventRef)cgEvent ofType:(CGEventType)type;
|
|
|
|
|
|
- (void)setUsingOMTCompositor:(BOOL)aUseOMTC;
|
|
- (void)setUsingOMTCompositor:(BOOL)aUseOMTC;
|
|
@@ -53,25 +53,25 @@ diff --git a/widget/cocoa/nsChildView.h b/widget/cocoa/nsChildView.h
|
|
+ (uint32_t)sUniqueKeyEventId;
|
|
+ (uint32_t)sUniqueKeyEventId;
|
|
|
|
|
|
+ (NSMutableDictionary*)sNativeKeyEventsMap;
|
|
+ (NSMutableDictionary*)sNativeKeyEventsMap;
|
|
-@@ -512,18 +511,16 @@ public:
|
|
|
|
|
|
+@@ -491,18 +490,16 @@ class nsChildView final : public nsBaseW
|
|
|
|
+ }
|
|
|
|
|
|
- already_AddRefed<mozilla::gfx::DrawTarget>
|
|
|
|
- StartRemoteDrawingInRegion(LayoutDeviceIntRegion& aInvalidRegion,
|
|
|
|
- mozilla::layers::BufferMode* aBufferMode) override;
|
|
|
|
|
|
+ already_AddRefed<mozilla::gfx::DrawTarget> StartRemoteDrawingInRegion(
|
|
|
|
+ LayoutDeviceIntRegion& aInvalidRegion, mozilla::layers::BufferMode* aBufferMode) override;
|
|
void EndRemoteDrawing() override;
|
|
void EndRemoteDrawing() override;
|
|
void CleanupRemoteDrawing() override;
|
|
void CleanupRemoteDrawing() override;
|
|
bool InitCompositor(mozilla::layers::Compositor* aCompositor) override;
|
|
bool InitCompositor(mozilla::layers::Compositor* aCompositor) override;
|
|
|
|
|
|
-- IAPZCTreeManager* APZCTM() { return mAPZC ; }
|
|
|
|
|
|
+- IAPZCTreeManager* APZCTM() { return mAPZC; }
|
|
-
|
|
-
|
|
- virtual MOZ_MUST_USE nsresult
|
|
|
|
- StartPluginIME(const mozilla::WidgetKeyboardEvent& aKeyboardEvent,
|
|
|
|
- int32_t aPanelX, int32_t aPanelY,
|
|
|
|
- nsString& aCommitted) override;
|
|
|
|
|
|
+ virtual MOZ_MUST_USE nsresult StartPluginIME(const mozilla::WidgetKeyboardEvent& aKeyboardEvent,
|
|
|
|
+ int32_t aPanelX, int32_t aPanelY,
|
|
|
|
+ nsString& aCommitted) override;
|
|
|
|
|
|
virtual void SetPluginFocused(bool& aFocused) override;
|
|
virtual void SetPluginFocused(bool& aFocused) override;
|
|
|
|
|
|
bool IsPluginFocused() { return mPluginFocused; }
|
|
bool IsPluginFocused() { return mPluginFocused; }
|
|
|
|
+
|
|
diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
--- a/widget/cocoa/nsChildView.mm
|
|
--- a/widget/cocoa/nsChildView.mm
|
|
+++ b/widget/cocoa/nsChildView.mm
|
|
+++ b/widget/cocoa/nsChildView.mm
|
|
@@ -94,7 +94,7 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
[NSMutableDictionary dictionary];
|
|
[NSMutableDictionary dictionary];
|
|
|
|
|
|
@interface ChildView(Private)
|
|
@interface ChildView(Private)
|
|
-@@ -203,38 +201,26 @@ static NSMutableDictionary* sNativeKeyEv
|
|
|
|
|
|
+@@ -202,38 +200,26 @@ static NSMutableDictionary* sNativeKeyEv
|
|
#endif
|
|
#endif
|
|
|
|
|
|
#ifdef ACCESSIBILITY
|
|
#ifdef ACCESSIBILITY
|
|
@@ -133,7 +133,7 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
- (CGSRegionObj)_regionForOpaqueDescendants:(NSRect)aRect forMove:(BOOL)aForMove;
|
|
- (CGSRegionObj)_regionForOpaqueDescendants:(NSRect)aRect forMove:(BOOL)aForMove;
|
|
- (CGSRegionObj)_regionForOpaqueDescendants:(NSRect)aRect forMove:(BOOL)aForMove forUnderTitlebar:(BOOL)aForUnderTitlebar;
|
|
- (CGSRegionObj)_regionForOpaqueDescendants:(NSRect)aRect forMove:(BOOL)aForMove forUnderTitlebar:(BOOL)aForUnderTitlebar;
|
|
@end
|
|
@end
|
|
-@@ -391,23 +377,16 @@ nsChildView::~nsChildView()
|
|
|
|
|
|
+@@ -390,23 +376,16 @@ nsChildView::~nsChildView()
|
|
}
|
|
}
|
|
|
|
|
|
NS_WARNING_ASSERTION(
|
|
NS_WARNING_ASSERTION(
|
|
@@ -157,7 +157,7 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
// mGeckoChild are used throughout the ChildView class to tell if it's safe
|
|
// mGeckoChild are used throughout the ChildView class to tell if it's safe
|
|
// to use a ChildView object.
|
|
// to use a ChildView object.
|
|
[mView widgetDestroyed]; // Safe if mView is nil.
|
|
[mView widgetDestroyed]; // Safe if mView is nil.
|
|
-@@ -1967,35 +1946,22 @@ nsChildView::CreateCompositor()
|
|
|
|
|
|
+@@ -1970,35 +1949,22 @@ nsChildView::CreateCompositor()
|
|
[(ChildView *)mView setUsingOMTCompositor:true];
|
|
[(ChildView *)mView setUsingOMTCompositor:true];
|
|
}
|
|
}
|
|
}
|
|
}
|
|
@@ -191,10 +191,10 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
LayoutDeviceIntRect
|
|
LayoutDeviceIntRect
|
|
nsChildView::RectContainingTitlebarControls()
|
|
nsChildView::RectContainingTitlebarControls()
|
|
{
|
|
{
|
|
- // Start with a thin strip at the top of the window for the highlight line.
|
|
|
|
- NSRect rect = NSMakeRect(0, 0, [mView bounds].size.width,
|
|
|
|
- [(ChildView*)mView cornerRadius]);
|
|
|
|
-@@ -4905,22 +4871,16 @@ GetIntegerDeltaForEvent(NSEvent* aEvent)
|
|
|
|
|
|
+ NSRect rect = NSZeroRect;
|
|
|
|
+
|
|
|
|
+ // If we draw the titlebar title string, set the rect to the full window
|
|
|
|
+@@ -4855,22 +4821,16 @@ GetIntegerDeltaForEvent(NSEvent* aEvent)
|
|
// For line scrolls, or pre-10.12, just use the rounded up value of deltaX / deltaY.
|
|
// For line scrolls, or pre-10.12, just use the rounded up value of deltaX / deltaY.
|
|
return gfx::IntPoint(RoundUp([aEvent deltaX]), RoundUp([aEvent deltaY]));
|
|
return gfx::IntPoint(RoundUp([aEvent deltaX]), RoundUp([aEvent deltaY]));
|
|
}
|
|
}
|
|
@@ -217,7 +217,7 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
return;
|
|
return;
|
|
}
|
|
}
|
|
|
|
|
|
-@@ -5030,115 +4990,16 @@ GetIntegerDeltaForEvent(NSEvent* aEvent)
|
|
|
|
|
|
+@@ -4980,115 +4940,16 @@ GetIntegerDeltaForEvent(NSEvent* aEvent)
|
|
wheelEvent.mLineOrPageDeltaX = lineOrPageDelta.x;
|
|
wheelEvent.mLineOrPageDeltaX = lineOrPageDelta.x;
|
|
wheelEvent.mLineOrPageDeltaY = lineOrPageDelta.y;
|
|
wheelEvent.mLineOrPageDeltaY = lineOrPageDelta.y;
|
|
geckoChildDeathGrip->DispatchAPZWheelInputEvent(wheelEvent, false);
|
|
geckoChildDeathGrip->DispatchAPZWheelInputEvent(wheelEvent, false);
|
|
@@ -333,7 +333,7 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
return nil;
|
|
return nil;
|
|
|
|
|
|
nsAutoRetainCocoaObject kungFuDeathGrip(self);
|
|
nsAutoRetainCocoaObject kungFuDeathGrip(self);
|
|
-@@ -5723,21 +5584,16 @@ GetIntegerDeltaForEvent(NSEvent* aEvent)
|
|
|
|
|
|
+@@ -5964,21 +5825,16 @@ GetIntegerDeltaForEvent(NSEvent* aEvent)
|
|
if (!mGeckoChild) {
|
|
if (!mGeckoChild) {
|
|
return LayoutDeviceIntPoint(0, 0);
|
|
return LayoutDeviceIntPoint(0, 0);
|
|
}
|
|
}
|
|
@@ -355,7 +355,7 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN;
|
|
NS_OBJC_BEGIN_TRY_ABORT_BLOCK_RETURN;
|
|
|
|
|
|
if (!mGeckoChild)
|
|
if (!mGeckoChild)
|
|
-@@ -6669,116 +6525,16 @@ ChildViewMouseTracker::WindowAcceptsEven
|
|
|
|
|
|
+@@ -6928,115 +6784,16 @@ ChildViewMouseTracker::WindowAcceptsEven
|
|
|
|
|
|
// If we're here then we're dealing with a left click or mouse move on an
|
|
// If we're here then we're dealing with a left click or mouse move on an
|
|
// inactive window or something similar. Ask Gecko what to do.
|
|
// inactive window or something similar. Ask Gecko what to do.
|
|
@@ -409,8 +409,7 @@ diff --git a/widget/cocoa/nsChildView.mm b/widget/cocoa/nsChildView.mm
|
|
-
|
|
-
|
|
-- (void)runEventThread
|
|
-- (void)runEventThread
|
|
-{
|
|
-{
|
|
-- char aLocal;
|
|
|
|
-- profiler_register_thread("APZC Event Thread", &aLocal);
|
|
|
|
|
|
+- PROFILER_REGISTER_THREAD("APZC Event Thread");
|
|
- NS_SetCurrentThreadName("APZC Event Thread");
|
|
- NS_SetCurrentThreadName("APZC Event Thread");
|
|
-
|
|
-
|
|
- mThread = [NSThread currentThread];
|
|
- mThread = [NSThread currentThread];
|