|
|
@@ -0,0 +1,32 @@
|
|
|
+# HG changeset patch
|
|
|
+# User Markus Stange <mstange@themasta.com>
|
|
|
+# Date 1518751772 18000
|
|
|
+# Node ID 2d086c21b2a17715efed3b8d08350b26deacb150
|
|
|
+# Parent bf6a4f1f64c1aa0e36f6a603a2558bbcfe95546c
|
|
|
+Bug 1385998 - Fix a typo in a comment.
|
|
|
+
|
|
|
+MozReview-Commit-ID: AiHDDUKGHhi
|
|
|
+
|
|
|
+diff --git a/js/public/ProfilingStack.h b/js/public/ProfilingStack.h
|
|
|
+--- a/js/public/ProfilingStack.h
|
|
|
++++ b/js/public/ProfilingStack.h
|
|
|
+@@ -48,17 +48,17 @@ class PseudoStack;
|
|
|
+ // (3) Thread A is resumed.
|
|
|
+ //
|
|
|
+ // Thread suspension is achieved using platform-specific APIs; refer to each
|
|
|
+ // platform's Sampler::SuspendAndSampleAndResumeThread implementation in
|
|
|
+ // platform-*.cpp for details.
|
|
|
+ //
|
|
|
+ // When the thread is suspended, the values in pseudoStack->stackPointer and in
|
|
|
+ // the entry range pseudoStack->entries[0..pseudoStack->stackPointer] need to
|
|
|
+-// be in a consistent state, so that thread A does not read partially-
|
|
|
++// be in a consistent state, so that thread S does not read partially-
|
|
|
+ // constructed profile entries. More specifically, we have two requirements:
|
|
|
+ // (1) When adding a new entry at the top of the stack, its ProfileEntry data
|
|
|
+ // needs to be put in place *before* the stackPointer is incremented, and
|
|
|
+ // the compiler + CPU need to know that this order matters.
|
|
|
+ // (2) When popping an entry from the stack and then preparing the
|
|
|
+ // ProfileEntry data for the next frame that is about to be pushed, the
|
|
|
+ // decrement of the stackPointer in pop() needs to happen *before* the
|
|
|
+ // ProfileEntry for the new frame is being popuplated, and the compiler +
|
|
|
+
|
Ian Neal