Browse Source

loader: actually look at return values from ModuleLoader QI

Mark Yen 12 years ago
parent
commit
f91f409467
1 changed files with 4 additions and 9 deletions
  1. 4 9
      xpcom/src/loader/pyloader.cpp

+ 4 - 9
xpcom/src/loader/pyloader.cpp

@@ -229,16 +229,11 @@ static nsresult PyxpcomModuleLoader(nsISupports* aOuter, REFNSIID aIID, void** a
     *aResult = nullptr;
     if (aOuter)
         return NS_ERROR_NO_AGGREGATION;
-    nsPythonModuleLoader* inst;
-    inst = new nsPythonModuleLoader();
-    if (NULL == inst) {
-        rv = NS_ERROR_OUT_OF_MEMORY;
-        return rv;
+    nsRefPtr<nsPythonModuleLoader> inst = new nsPythonModuleLoader();
+    if (!inst) {
+        return NS_ERROR_OUT_OF_MEMORY;
     }
-    NS_ADDREF(inst);
-    rv = inst->QueryInterface(aIID, aResult);
-    NS_RELEASE(inst);
-    return NS_OK;
+    return inst->QueryInterface(aIID, aResult);
 }