#26 Interpret empty or whitespace root margin string as zero length for the IntersectionObserver

Closed
opened 3 months ago by mattatobin · 0 comments

With the kind help of FranklinDM we can now achieve this with c89bbcef39 but there is a question if the change should be confined to DOMIntersectionObserver.cpp or be made to CSSParserImpl::ParseMarginString. While in Mozilla code this was eventually taken over by Rust we might need to use the parser method in the future without the margin accepting zero length values or refactoring into a more generic method.

Right now I am inclined to leave the change as-is and change it to match whatever UXP adopts if there is no sign the code in the CSS Parser will be used for anything else in the future.


UXP Issue 1881

With the kind help of FranklinDM we can now achieve this with c89bbcef39fb605460edc2f8d3b447eff72b074d but there is a question if the change should be confined to `DOMIntersectionObserver.cpp` or be made to `CSSParserImpl::ParseMarginString`. While in Mozilla code this was eventually taken over by `Rust` we might need to use the parser method in the future without the margin accepting zero length values or refactoring into a more generic method. Right now I am inclined to leave the change as-is and change it to match whatever `UXP` adopts if there is no sign the code in the CSS Parser will be used for anything else in the future. ---- [UXP Issue 1881](https://repo.palemoon.org/MoonchildProductions/UXP/issues/1881)
Sign in to join this conversation.
No Milestone
No assignee
1 Participants
Loading...
Cancel
Save
There is no content yet.