#25 Remove EME and GMP

Closed
opened 7 months ago by mattatobin ยท 3 comments

Due to Moonchild once again botching code removals I had to re-add EME and GMP back to the codebase in Issue #1 so that Youtube Streams would work again.

It is still unknown why or how conditional code that is not built or pre-processed out has the effect of busting YT Streams so research is required to find out why.

In the meantime, we should ifdef GMP and remove what sub-components we can without sacrificing viability.

Due to Moonchild once again botching code removals I had to re-add `EME` and `GMP` back to the codebase in Issue #1 so that Youtube Streams would work again. It is still unknown why or how conditional code that is not built or pre-processed out has the effect of busting YT Streams so research is required to find out why. In the meantime, we should ifdef `GMP` and remove what sub-components we can without sacrificing viability.

So after I removed all conditional EME code Youtube Streams still work. Both over all changesets are very large so I am not sure where the difference is but obviously.. Moonchild fucked SOMETHING up.

Removing GMP will be harder cause I am not going to reuse the work done before. At least not directly. I will proceed by first ifdef'ing GMP code and once it is all isolated then it will be removed. Just like I asked to be done for literal years.

So after I removed all conditional `EME` code Youtube Streams still work. Both over all changesets are very large so I am not sure where the difference is but obviously.. Moonchild fucked SOMETHING up. Removing `GMP` will be harder cause I am not going to reuse the work done before. At least not directly. I will proceed by first ifdef'ing GMP code and once it is all isolated then it will be removed. Just like I asked to be done for literal years.

I found five lines of code removed that shouldn't have been. THIS is why my removal worked and his didn't. Without those lines I get the behavior that spawned this whole thing.

While some logic around those lines needs cleaned up.. They are essential to Youtube Stream MSE working.

But GRE was a bust right? And it was a bust because of me. Uhh-huh.

I found five lines of code removed that shouldn't have been. THIS is why my removal worked and his didn't. Without those lines I get the behavior that spawned this whole thing. While some logic around those lines needs cleaned up.. They are essential to Youtube Stream MSE working. But `GRE` was a bust right? And it was a bust because of me. Uhh-huh.

There may still be tiny tidbits of leftovers but I am gonna close this. Will follow up if something presents its self.

There may still be tiny tidbits of leftovers but I am gonna close this. Will follow up if something presents its self.
Sign in to join this conversation.
No Milestone
No assignee
1 Participants
Loading...
Cancel
Save
There is no content yet.